bullet.pc file wrong, please remove INCLUDE_INSTALL_DIR

[elLolo]

Hi!

the Bullet.pc file is not filled correctly, for example:

Code: Select all

Name: bullet
Description: Bullet Continuous Collision Detection and Physics Library
Requires:
Version: 2.77
Libs: -L/local/laguerre/Prog/Installs/Bullet/lib -lBulletSoftBody -lBulletDynamics -lBulletCollision -lLinearMath
Cflags: -I/local/laguerre/Prog/Installs/Bullet/include/bullet

The line for Cflags should not add "bullet" at its end because headers are installed in "include" not "include/bullet". This behavior comes from the INCLUDE_INSTALL_DIR variable that is set by the Bullet/CmakeList.txt file. In my opinion, this setting is currently not useful because CMake scripts for file installations don't take this variable into account. For example, in Bullet/src/BulletDynamics, the file CMakeLists.txt contains this line (#109):

Code: Select all

INSTALL(FILES ../btBulletDynamicsCommon.h DESTINATION include/BulletDynamics)

which means that header files will unconditionally be installed into "include".

As a consequence, I suggest to remove the INCLUDE_INSTALL_DIR variable since it isn't used or to use it when needed in many CMake script files.

[Erwin Coumans]

Thanks for the feedback, we are not actively supporting 'installing' Bullet and bullet.pc, pkgconfig etc, so your help is welcome.

Added to this issue http://code.google.com/p/bullet/issues/detail?id=421
Thanks,
Erwin

[Erwin Coumans]

I'm looking into using this INCLUDE_INSTALL_DIR in the cmake CMakeLists.txt INSTALL sections, so that the bullet.pc.cmake file is correct.

Thanks,
Erwin