Add/Remove improvement

[Jack]

I suggest to improve addRigidBody and removeRigidBody. It would be very nice to return bool result of the function. Return true, if object was actually added/removed. Return false if object already exists (for Add operation) or if object is not in scene (for Remove operation)...................................

[Jack]

[jacmoe]

If you are keen on getting this functionality, submit a patch, Jack!
That way this doesn't get lost because Erwin didn't see it.

[Erwin Coumans]

It would be better if the user doesn't try to add objects twice, or try to remove objects that are not added. But it's easy to add such feedback, so I'll add it.

Thanks for the suggestion,
Erwin

[Jack]

It would be better if the user doesn't try to add objects twice, or try to remove objects that are not added. But it's easy to add such feedback, so I'll add it.

Thanks for the suggestion,
Erwin

not added in 2.37

[jacmoe]

It would be better if you kept track of what objects you did add, so that you can remove those.
You should do that in your physics/collision manager.
If the lack of this feature prevents you from using Bullet, you have serious issues in your coding.

If you really want this, and can't wait: Do It Yourself.

[Erwin Coumans]

But it's easy to add such feedback, so I'll add it.

It's not that easy actually, it would make the API inconsistent:
The problem is that once you start with such 'improvement' there is no end... to be consistent, all API's should return true/false.

It's best to just do the check on the application side. Why would someone want to delete random things he doesn't know if they are already deleted?

I can help by adding a 'findRigidbody', and you just call that first.
Would that help?

Erwin

[Jack]

But it's easy to add such feedback, so I'll add it.

It's not that easy actually, it would make the API inconsistent:
The problem is that once you start with such 'improvement' there is no end... to be consistent, all API's should return true/false.

It's best to just do the check on the application side. Why would someone want to delete random things he doesn't know if they are already deleted?

I can help by adding a 'findRigidbody', and you just call that first.
Would that help?

Erwin

Well...Let's come from other side.
It would be useful if Rigidbody could mantain IN_SCENE flag. You set/reset IN_SCENE flag on add/remove operation. And there will be new method in Rigidbody: bool isInScene(void). Like isStaticObject(), isKinematicObject()....Great?

P.S. Not only me, but you also need this flag. You need it to prevent adding body in several scenes at the same time....

[Erwin Coumans]

rigidbody->getBroadphaseHandle() returns non-zero when the body is added to the dynamics/collision world, and 0 when remove/not added.
We can have some bool isInWorld() checking this getBroadphaseHandle.

Does that help?
Erwin

Well...Let's come from other side.
It would be useful if Rigidbody could mantain IN_SCENE flag. You set/reset IN_SCENE flag on add/remove operation. And there will be new method in Rigidbody: bool isInScene(void). Like isStaticObject(), isKinematicObject()....Great?

[Jack]

Yes. That is OK!

rigidbody->getBroadphaseHandle() returns non-zero when the body is added to the dynamics/collision world, and 0 when remove/not added.
We can have some bool isInWorld() checking this getBroadphaseHandle.

Does that help?
Erwin

Well...Let's come from other side.
It would be useful if Rigidbody could mantain IN_SCENE flag. You set/reset IN_SCENE flag on add/remove operation. And there will be new method in Rigidbody: bool isInScene(void). Like isStaticObject(), isKinematicObject()....Great?