64bit compilation problem, daeWin32Platform.h

[Dragonlord]

BulletExtras/COLLADA_DOM/include/dae/daeWin32Platform.h incorrectly defined intptr_t causing problems:

Code: Select all

C:\Daten\dragengine\src\modules\physics\bullet/BulletExtras/COLLADA_DOM/include/dae/daeWin32Platform.h:29:13: error: conflicting declaration 'typedef int intptr_t'
c:/mingw/lib/gcc/../../x86_64-w64-mingw32/include/_mingw.h:305:37: error: 'intptr_t' has a previous declaration as 'typedef long long int intptr_t'

An #ifdef should be placed around this definition as user code can include <stdint.h> already prior to this header as well as compilers potentially predefining this.

EDIT: Precision. with the #ifdef I referred to _MSC_VER. The check requires this symbol to be defined but only VC does define this. Correctly the check should be #if defined(_MSC_VER) && (existing symbol check). Then this code compiles properly.

[Erwin Coumans]

We moved the COLLADA stuff to the Dynamica repository. Could you file a bug (and perhaps a patch) to the issue tracker of Dynamica here?

http://dynamica.googlecode.com

Thanks!
Erwin

[Dragonlord]

What version is the library there? As I assume my version here is perhaps not the most recent. Patching against a non-matching version is not the best idea although I doubt that header changed much in that part. It's really just one line of text replaced so a verbal patch would be enough I think.