DBG_DrawWireframe & ActivationState

pc0de
Posts: 3
Joined: Sun Oct 29, 2006 5:04 pm

DBG_DrawWireframe & ActivationState

Post by pc0de »

When running with DBG_DrawWireframe set, debugDrawObject is sending Red only.

It appears the following patch fixes the problem:

Code: Select all

Index: src/BulletDynamics/Dynamics/btDiscreteDynamicsWorld.cpp
===================================================================
--- src/BulletDynamics/Dynamics/btDiscreteDynamicsWorld.cpp	(revision 401)
+++ src/BulletDynamics/Dynamics/btDiscreteDynamicsWorld.cpp	(working copy)
@@ -127,15 +127,15 @@
 			switch(colObj->GetActivationState())
 			{
 			case  ACTIVE_TAG:
-				color = btVector3(255.f,255.f,255.f);
+				color = btVector3(255.f,255.f,255.f); break;
 			case ISLAND_SLEEPING:
-				color =  btVector3(0.f,255.f,0.f);
+				color =  btVector3(0.f,255.f,0.f); break;
 			case WANTS_DEACTIVATION:
-				color = btVector3(0.f,255.f,255.f);
+				color = btVector3(0.f,255.f,255.f); break;
 			case DISABLE_DEACTIVATION:
-				color = btVector3(255.f,0.f,0.f);
+				color = btVector3(255.f,0.f,0.f); break;
 			case DISABLE_SIMULATION:
-				color = btVector3(255.f,255.f,0.f);
+				color = btVector3(255.f,255.f,0.f); break;
 			default:
 				{
 					color = btVector3(255.f,0.f,0.f);
Is this forum a good place to submit patches?

pc0de
User avatar
Erwin Coumans
Site Admin
Posts: 4221
Joined: Sun Jun 26, 2005 6:43 pm
Location: California, USA

Re: DBG_DrawWireframe & ActivationState

Post by Erwin Coumans »

pc0de wrote:When running with DBG_DrawWireframe set, debugDrawObject is sending Red only.

It appears the following patch fixes the problem (break missing).

Is this forum a good place to submit patches?

pc0de
Thanks a lot, this forum is definately the right place to report bugs/submit patches. Your patch is already applied in the SVN repository, and in the next 2.20 release (later today) it will be fixed.

Erwin
pc0de
Posts: 3
Joined: Sun Oct 29, 2006 5:04 pm

Post by pc0de »

Thanks Erwin for the quick response as well as the work you're doing here.