btQuickprof.h macro redefinition WIN32_LEAN_AND_MEAN

[Prompt]

btQuickprof.h file at revisión 2171, the last revision at this time.

Ok, line 43 have:

Code: Select all

#if defined(WIN32) || defined(_WIN32)

#define USE_WINDOWS_TIMERS 
#define WIN32_LEAN_AND_MEAN 
#define NOWINRES 
#define NOMCX 
#define NOIME 
#ifdef _XBOX
...

My proposal is to use #undef or #ifndef or nothing. I said that because this macro is really basic and global in my project setting and I'm sure normally all people working to support some platforms want to use this macro and have this macro like global setting.

With the current source code Bullet library add this global macro wherever this file are included, modifying your engine configuration. So in my opinion this macro must be a recommendation in project configuration for Bullet users. Now Bullet library force to use a global configuration in all places that derives of bullet source code. I believe is needed to change this for coherence with project / compiler configuration.

Thanks in advance!

[Erwin Coumans]

Could you provide the feedback/patch in this issue in the tracker?

http://code.google.com/p/bullet/issues/detail?id=113

Also, could you please reply the 3ds Max topic? http://bulletphysics.org/Bullet/phpBB3/ ... =12&t=5458
Thanks a lot for the help,
Erwin

[Prompt]

I Will modify the 2 files and attach in the issue wait a moment I can to make more comprehensible this 2 files.

[Prompt]

I sent a patch

Thanks for all,
Alvaro Martin.

[Erwin Coumans]

Fixed the issue with WIN32_LEAN_AND_MEAN in Bullet trunk:

http://code.google.com/p/bullet/source/detail?r=2177

Thanks for the feedback!
Erwin