Current SVN Cmake HtFluidDemo broke
-
- Posts: 1
- Joined: Sat Jan 24, 2009 10:13 pm
Current SVN Cmake HtFluidDemo broke
The current CMake file for the HeightFluidDemo from SVN is broke. On line 20 the prefix lib must be removed to allow Cmake to configure correctly. Attached is the modified CmakeLists.txt that works for me.
You do not have the required permissions to view the files attached to this post.
-
- Posts: 28
- Joined: Mon Jun 02, 2008 7:21 pm
Re: Current SVN Cmake HtFluidDemo broke
I can confirm that this is an issue. These libraries used to use the "Lib" prefix, but not in current svn, and removing the "Lib" prefix from the library names in CMakeLists.txt (as IsaacG suggests) resolves the issue.
In general, what is the formal mechanism for submitting fixes for issues like these? (Erwin, John?)
-Paul
In general, what is the formal mechanism for submitting fixes for issues like these? (Erwin, John?)
-Paul
-
- Posts: 133
- Joined: Wed Jul 27, 2005 1:05 pm
- Location: Berkeley, CA
Re: Current SVN Cmake HtFluidDemo broke
Hi,
The preferred method for submitting bug fixes to Bullet is to file an issue in the google issue tracker and attach any patches there.
Thanks,
John
The preferred method for submitting bug fixes to Bullet is to file an issue in the google issue tracker and attach any patches there.
Thanks,
John
-
- Posts: 133
- Joined: Wed Jul 27, 2005 1:05 pm
- Location: Berkeley, CA
Re: Current SVN Cmake HtFluidDemo broke
FYI,
I just committed a fix for this problem. I had fixed it last week but I forgot to commit it.
Thanks,
John
I just committed a fix for this problem. I had fixed it last week but I forgot to commit it.
Thanks,
John
-
- Posts: 144
- Joined: Fri Aug 01, 2008 6:36 am
- Location: Bonn, Germany
Re: Current SVN Cmake HtFluidDemo broke
Hello, there is a little problem in that patch in CMakeList.txt, line 7
// SET(CMAKE_BUILD_TYPE "Debug")
("//" instead "#"), it breaks cmake. Thanks ...
// SET(CMAKE_BUILD_TYPE "Debug")
("//" instead "#"), it breaks cmake. Thanks ...
-
- Posts: 133
- Joined: Wed Jul 27, 2005 1:05 pm
- Location: Berkeley, CA
Re: Current SVN Cmake HtFluidDemo broke
doh. Fixed in SVN.
-
- Posts: 28
- Joined: Mon Jun 02, 2008 7:21 pm
Re: Current SVN Cmake HtFluidDemo broke
Thanks, John, for commiting this, and for the info about posting patches to the Google group. Tested current svn and all builds fine using CMake and VS8/WinXP.