Are those small and fast moving balls? Are you using a large/variable timestep?I got a lot of 'falling through the ground' with tri-meshes as ground and just balls
If you can reproduce it in a modified Bullet demo, it would be useful.
Thanks!
Erwin
Are those small and fast moving balls? Are you using a large/variable timestep?I got a lot of 'falling through the ground' with tri-meshes as ground and just balls
- The balls are ~0.6 units (radius). They are moving at 0.0 to 2.0 units per second. Typically I setup with a ball at ~8 cm above ground level and it falls right through when the simulation starts, apparently under the influence of gravity ( 9.8 )Erwin Coumans wrote: Are those small and fast moving balls? Are you using a large/variable timestep?
Erwin
Which is why the documentation in the headers should contain at the very least enough information to the user for him/her to be able to use it.VicariousEnt wrote:I consider documention to have failed in its purpose if I ever have to open a .cpp to figure out how to use an interface.
Martin Felis wrote:Maybe one can join the documentation efforts and knowledge gained by users/devs?
If anyone has added some Doxygen comments flying around, I'd be happy to add them to https://github.com/martinfelis/bulletphysics2.
I agree with Karrok, that the steps he suggested would help. However I think sending patches to the googlecode issue would load more work on the developers with write access to the repository at googlecode. It would thus take some time until the documentation gets available to everyone (not counting downloading all documentation patches by hand).Karrok wrote:Wouldn't it be better to supply the additional doxygen commented parts as patch suggestions to Erwin?
It should be fairly easy:
1. Get the SVN repo of Bullet (not the zip)
2. Make the comment/doxygen additions (trying to make them as extensive as might be needed)
3. Create an svn patch.
4. Post it under googlecode issue at: http://code.google.com/p/bullet/issues/detail?id=42
This way the documentation can take shape in a somewhat more organised fashion, and Erwin can check each submitted patch on correctness and completeness and make corrections if needed before it is commited to the main lead. I think this might be preferable to having a separate repo.
I think most of us agree that the code could use more commenting. And personally I don't have any preference where exactly it should be stored, however I do have a strong preference towards doing something about the documentation instead of discussing where to put it the Best Way Possible.monkeyman wrote:So to summarize, the API-parts, doxygen generated documentation etc is good to fix but not the biggest issue I think. A physics engine is (currently) an incredibly complicated piece of algorithmic machinery, and I would not expect the parts to be perfect, so prioritizing actually helping programmers understand the code itself would help a lot in the long run, because it would generate more code-submissions in return, hopefully
I did exactly that for the btKinematicCharacterController. You can have a look at it at https://github.com/martinfelis/bulletphysics2. If you have made any documentation efforts yourself I would be happy to add them.monkeyman wrote:So to summarize, the API-parts, doxygen generated documentation etc is good to fix but not the biggest issue I think. A physics engine is (currently) an incredibly complicated piece of algorithmic machinery, and I would not expect the parts to be perfect, so prioritizing actually helping programmers understand the code itself would help a lot in the long run, because it would generate more code-submissions in return, hopefully