Current SVN Cmake HtFluidDemo broke

Post Reply
IsaacG
Posts: 1
Joined: Sat Jan 24, 2009 10:13 pm

Current SVN Cmake HtFluidDemo broke

Post by IsaacG »

The current CMake file for the HeightFluidDemo from SVN is broke. On line 20 the prefix lib must be removed to allow Cmake to configure correctly. Attached is the modified CmakeLists.txt that works for me.
Attachments
CMakeLists.zip
(603 Bytes) Downloaded 354 times
PaulMartz
Posts: 28
Joined: Mon Jun 02, 2008 7:21 pm

Re: Current SVN Cmake HtFluidDemo broke

Post by PaulMartz »

I can confirm that this is an issue. These libraries used to use the "Lib" prefix, but not in current svn, and removing the "Lib" prefix from the library names in CMakeLists.txt (as IsaacG suggests) resolves the issue.

In general, what is the formal mechanism for submitting fixes for issues like these? (Erwin, John?)
-Paul
User avatar
John McCutchan
Posts: 133
Joined: Wed Jul 27, 2005 1:05 pm
Location: Berkeley, CA
Contact:

Re: Current SVN Cmake HtFluidDemo broke

Post by John McCutchan »

Hi,

The preferred method for submitting bug fixes to Bullet is to file an issue in the google issue tracker and attach any patches there.

Thanks,
John
User avatar
John McCutchan
Posts: 133
Joined: Wed Jul 27, 2005 1:05 pm
Location: Berkeley, CA
Contact:

Re: Current SVN Cmake HtFluidDemo broke

Post by John McCutchan »

FYI,

I just committed a fix for this problem. I had fixed it last week but I forgot to commit it.

Thanks,
John
mi076
Posts: 144
Joined: Fri Aug 01, 2008 6:36 am
Location: Bonn, Germany

Re: Current SVN Cmake HtFluidDemo broke

Post by mi076 »

Hello, there is a little problem in that patch in CMakeList.txt, line 7
// SET(CMAKE_BUILD_TYPE "Debug")
("//" instead "#"), it breaks cmake. Thanks ...
User avatar
John McCutchan
Posts: 133
Joined: Wed Jul 27, 2005 1:05 pm
Location: Berkeley, CA
Contact:

Re: Current SVN Cmake HtFluidDemo broke

Post by John McCutchan »

doh. Fixed in SVN.
PaulMartz
Posts: 28
Joined: Mon Jun 02, 2008 7:21 pm

Re: Current SVN Cmake HtFluidDemo broke

Post by PaulMartz »

Thanks, John, for commiting this, and for the info about posting patches to the Google group. Tested current svn and all builds fine using CMake and VS8/WinXP.
Post Reply